{
  "__type": "IngestedDoc",
  "__tag": 4010,
  "_content": {},
  "_ordered_sections": [],
  "item_file": null,
  "item_line": null,
  "item_type": null,
  "aliases": [],
  "example_section_data": {
    "__type": "Section",
    "__tag": 4015,
    "children": [],
    "title": [],
    "level": 0,
    "target": null
  },
  "see_also": [],
  "signature": null,
  "references": null,
  "qa": "dev:contributor:reviewing_prs",
  "arbitrary": [
    {
      "__type": "Section",
      "__tag": 4015,
      "children": [],
      "title": [
        {
          "__type": "Text",
          "__tag": 4046,
          "value": "Reviewing Pull Requests"
        }
      ],
      "level": 0,
      "target": "reviewing-prs"
    },
    {
      "__type": "Section",
      "__tag": 4015,
      "children": [
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "When reviewing pull requests, please use workflow tracking features on Github as appropriate:"
            }
          ]
        },
        {
          "__type": "BulletList",
          "__tag": 4053,
          "ordered": true,
          "start": 1,
          "children": [
            {
              "__type": "ListItem",
              "__tag": 4054,
              "children": [
                {
                  "__type": "Paragraph",
                  "__tag": 4045,
                  "children": [
                    {
                      "__type": "Text",
                      "__tag": 4046,
                      "value": "After you have finished reviewing, and want to ask for the submitter    to make the changes:"
                    }
                  ]
                },
                {
                  "__type": "BulletList",
                  "__tag": 4053,
                  "ordered": false,
                  "start": 1,
                  "children": [
                    {
                      "__type": "ListItem",
                      "__tag": 4054,
                      "children": [
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "Change your review status to \"Changes requested\"."
                            }
                          ]
                        },
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "This can be done on Github, PR page, "
                            },
                            {
                              "__type": "InlineCode",
                              "__tag": 4051,
                              "value": "Files changed"
                            },
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": " tab,      "
                            },
                            {
                              "__type": "InlineCode",
                              "__tag": 4051,
                              "value": "Review changes"
                            },
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": " (button on top right)."
                            }
                          ]
                        }
                      ]
                    },
                    {
                      "__type": "ListItem",
                      "__tag": 4054,
                      "children": [
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "Alternatively: add the "
                            },
                            {
                              "__type": "InlineCode",
                              "__tag": 4051,
                              "value": "needs-work"
                            },
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": " label."
                            }
                          ]
                        },
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "This can be done on the PR page, "
                            },
                            {
                              "__type": "InlineCode",
                              "__tag": 4051,
                              "value": "Labels"
                            },
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": " menu on the right."
                            }
                          ]
                        }
                      ]
                    }
                  ]
                }
              ]
            },
            {
              "__type": "ListItem",
              "__tag": 4054,
              "children": [
                {
                  "__type": "Paragraph",
                  "__tag": 4045,
                  "children": [
                    {
                      "__type": "Text",
                      "__tag": 4046,
                      "value": "When you re-review the same pull request again, and want to request    more changes:"
                    }
                  ]
                },
                {
                  "__type": "BulletList",
                  "__tag": 4053,
                  "ordered": false,
                  "start": 1,
                  "children": [
                    {
                      "__type": "ListItem",
                      "__tag": 4054,
                      "children": [
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "Do the \"Changes requested\" thing again, even if the previous status      was also 'Changes requested'."
                            }
                          ]
                        }
                      ]
                    },
                    {
                      "__type": "ListItem",
                      "__tag": 4054,
                      "children": [
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "Alternatively:      Remove the existing "
                            },
                            {
                              "__type": "InlineCode",
                              "__tag": 4051,
                              "value": "needs-work"
                            },
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": " label, and then re-add the label      back again. (Github will add a notice on the page that you did so.)"
                            }
                          ]
                        }
                      ]
                    }
                  ]
                }
              ]
            },
            {
              "__type": "ListItem",
              "__tag": 4054,
              "children": [
                {
                  "__type": "Paragraph",
                  "__tag": 4045,
                  "children": [
                    {
                      "__type": "Text",
                      "__tag": 4046,
                      "value": "If you're happy about the current status:"
                    }
                  ]
                },
                {
                  "__type": "BulletList",
                  "__tag": 4053,
                  "ordered": false,
                  "start": 1,
                  "children": [
                    {
                      "__type": "ListItem",
                      "__tag": 4054,
                      "children": [
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "Mark the pull request as Approved (same way as Changes requested)."
                            }
                          ]
                        }
                      ]
                    },
                    {
                      "__type": "ListItem",
                      "__tag": 4054,
                      "children": [
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "Alternatively: remove the "
                            },
                            {
                              "__type": "InlineCode",
                              "__tag": 4051,
                              "value": "needs-work"
                            },
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": " label."
                            }
                          ]
                        }
                      ]
                    },
                    {
                      "__type": "ListItem",
                      "__tag": 4054,
                      "children": [
                        {
                          "__type": "Paragraph",
                          "__tag": 4045,
                          "children": [
                            {
                              "__type": "Text",
                              "__tag": 4046,
                              "value": "Alternatively (for core developers): merge the pull request, if      you think it is ready to be merged."
                            }
                          ]
                        }
                      ]
                    }
                  ]
                }
              ]
            }
          ]
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "This allows automatically tracking which PRs are in need of attention."
            }
          ]
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "Some of the information is also visible on Github directly, although (as of Aug 2019) Github does not show which pull requests have been updated since the last review."
            }
          ]
        }
      ],
      "title": [
        {
          "__type": "Text",
          "__tag": 4046,
          "value": "Using workflow features"
        }
      ],
      "level": 1,
      "target": "pull-request-workflow-features"
    },
    {
      "__type": "Section",
      "__tag": 4015,
      "children": [
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "When you review a pull request created by someone else, it's helpful to have a copy of their code on your own machine so that you can play with it locally."
            }
          ]
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "One way to install "
            },
            {
              "__type": "Link",
              "__tag": 4049,
              "children": [
                {
                  "__type": "Text",
                  "__tag": 4046,
                  "value": "the GitHub CLI"
                }
              ],
              "url": "https://cli.github.com/",
              "title": ""
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": ", then navigate to the SciPy root directory in the terminal and enter     "
            }
          ]
        },
        {
          "__type": "Code",
          "__tag": 4050,
          "value": "gh pr checkout PULL_REQUEST_ID",
          "execution_status": null
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "where "
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "PULL_REQUEST_ID"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": " is the five digit number corresponding with the pull request (e.g. "
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "10286"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": " for "
            },
            {
              "__type": "Link",
              "__tag": 4049,
              "children": [
                {
                  "__type": "Text",
                  "__tag": 4046,
                  "value": "PR #10286"
                }
              ],
              "url": "https://github.com/scipy/scipy/pull/10286",
              "title": ""
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "). This immediately checks out the pull request into a branch with a name matching the one the PR author used."
            }
          ]
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "Assuming you set up your development environment according to "
            },
            {
              "__type": "CrossRef",
              "__tag": 4002,
              "value": "building-from-source",
              "reference": {
                "__type": "LocalRef",
                "__tag": 4022,
                "kind": "docs",
                "path": "building:index"
              },
              "kind": "exists"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": ", you can now activate your development environment     "
            }
          ]
        },
        {
          "__type": "Code",
          "__tag": 4050,
          "value": "conda activate scipy-dev",
          "execution_status": null
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "build the code and test it     "
            }
          ]
        },
        {
          "__type": "Code",
          "__tag": 4050,
          "value": "spin test -v",
          "execution_status": null
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "and if you "
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "import"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": " SciPy from within IPython (start it with "
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "spin ipython"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "), you'll be importing the author's modified version of SciPy."
            }
          ]
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "If you want to collaborate with the author on their PR, you might instead want to set up a new remote to the author's fork of SciPy     "
            }
          ]
        },
        {
          "__type": "Code",
          "__tag": 4050,
          "value": "git remote add REMOTE_NAME https://github.com/AUTHOR/scipy.git",
          "execution_status": null
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "where "
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "AUTHOR"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": " is the author's GitHub user name and "
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "REMOTE_NAME"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": " is whatever name you want to use to refer to this author's repository."
            }
          ]
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "From there, you can view the author's branches     "
            }
          ]
        },
        {
          "__type": "Code",
          "__tag": 4050,
          "value": "git remote show REMOTE_NAME",
          "execution_status": null
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "and create your own branch based on one of them     "
            }
          ]
        },
        {
          "__type": "Code",
          "__tag": 4050,
          "value": "git checkout --track REMOTE_NAME/BRANCH_NAME",
          "execution_status": null
        },
        {
          "__type": "Paragraph",
          "__tag": 4045,
          "children": [
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "where "
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "BRANCH_NAME"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": " is the name of the branch you want to start from. This creates a copy of this branch (with the same name) in your local repository. If you make changes to this branch and push to your GitHub repository ("
            },
            {
              "__type": "InlineCode",
              "__tag": 4051,
              "value": "origin"
            },
            {
              "__type": "Text",
              "__tag": 4046,
              "value": "), you can then create a pull request to merge your changes with the author's repository."
            }
          ]
        },
        {
          "__type": "Target",
          "__tag": 4061,
          "label": "PR #10286"
        }
      ],
      "title": [
        {
          "__type": "Text",
          "__tag": 4046,
          "value": "Code from pull request"
        }
      ],
      "level": 1,
      "target": null
    }
  ],
  "local_refs": []
}